feat: [IOCOM-2586] AAR Phase 2 tracking #7546
Open
+452,189
−5,607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p type in the action props
…ing logic to the Send Engagement screen
…nResultScreenContent
…-engagement-screen
…OperationResultScreenContent" This reverts commit bd9821f.
…idth prop type in the action props" This reverts commit f963ccc.
…ction props and update snapshots
…ScreenContent with WhatsNewScreenContent
forrest57
reviewed
Nov 3, 2025
| export const SendAARErrorScreen = () => { | ||
| const flowType = useIOSelector(currentAARFlowStateType); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
why not use useOnFirstRender?
There was a problem hiding this comment.
I don't like the fact that it is a custom hook with an inside ref and that it allows the developer to not include the necessary dependencies in the callback. Moreover, in case of a (wrong) re-rendering, it does not run again but if the component is unmounted and mounted again (due to parent inclusion), then it does run again, against the fact that it is called "useOnFirstRender"
# Conflicts: # ts/features/pn/aar/components/SendAARMessageDetailBottomSheet.tsx # ts/features/pn/aar/components/SendAARMessageDetailBottomSheetComponent.tsx # ts/features/pn/aar/components/__tests__/SendAARMessageDetailBottomSheet.test.tsx # ts/features/pn/screens/__test__/__snapshots__/MessageDetailsScreen.test.tsx.snap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the tracking events for the AAR Phase 2.
List of changes proposed in this pull request
SEND_TEMPORARY_NOTIFICATION_OPENING_DISCLAIMER: screen view on ToSSEND_TEMPORARY_NOTIFICATION_OPENING_DISCLAIMER_ACCEPTED: accept on ToSSEND_TEMPORARY_NOTIFICATION_OPENING_DISCLAIMER_DISMISSED: denial on ToSSEND_TEMPORARY_NOTIFICATION_OPENING_NOT ALLOWED: screen view when user is not the recipientSEND_TEMPORARY_NOTIFICATION_OPENING_NOT_ALLOWED_MANDATE_INFO: tap on more info when user is not the recipientSEND_TEMPORARY_NOTIFICATION_OPENING_NOT_ALLOWED_DISMISSED: tap on close when user is not the recipientPN_UX_SUCCESS: propertiessend_userandopening_sourceaddedPN_NOTIFICATION_LOAD_SUCCESS: propertiessend_userandopening_sourceaddedPN_PAYMENT_STATUS: propertiessend_userandopening_sourceaddedPN_ATTACHMENT_OPENING: propertiessend_userandopening_sourceaddedPN_PAYMENT_START: propertiessend_userandopening_sourceaddedPN_SHOW_TIMELINE: propertiessend_userandopening_sourceaddedPN_SHOW_F24: propertiessend_userandopening_sourceaddedPN_TIMELINE_EXTERNAL: propertiessend_userandopening_sourceaddedSEND_TEMPORARY_NOTIFICATION_CLOSURE: screen view upon showing the bottom sheet, leaving the AAR notificationSEND_TEMPORARY_NOTIFICATION_CLOSURE_BACK: tap on "back to notification" in the bottom sheet aboveSEND_TEMPORARY_NOTIFICATION_CLOSURE_CONFIRM: tap on "close" in the bottom sheet aboveSEND_TEMPORARY_NOTIFICATION_CLOSURE_EXIT: tap on external link in the bottom sheet aboveSEND_AAR_ERROR_CLOSURE: tap on close in the error screenSEND_AAR_ERROR_DETAIL: tap on details in the error screenSEND_AAR_ERROR_DETAIL_HELP: tap on chat assistance in the error screenSEND_AAR_ERROR_DETAIL_CODE: tap on assistance code copy in the error screenHow to test
Use the io-dev-api-server to simulate every possible flow and check that every event is raised the right number of times, with proper parameters